iotdb-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [iotdb] cmlmakahts commented on a change in pull request #3474: [IOTDB-1456] Fix Error occurred while executing delete timeseries statement
Date Tue, 20 Jul 2021 03:21:47 GMT

cmlmakahts commented on a change in pull request #3474:
URL: https://github.com/apache/iotdb/pull/3474#discussion_r672775050



##########
File path: cluster/src/main/java/org/apache/iotdb/cluster/log/applier/BaseApplier.java
##########
@@ -102,6 +104,16 @@ private void handleBatchProcessException(BatchProcessException e, PhysicalPlan
p
           && plan instanceof BatchPlan) {
         ((BatchPlan) plan).setIsExecuted(i);
       }
+
+      if (plan instanceof DeleteTimeSeriesPlan) {
+        if (status != null && status.getCode() != TSStatusCode.SUCCESS_STATUS.getStatusCode())
{
+          if (status.getCode() != TSStatusCode.TIMESERIES_NOT_EXIST.getStatusCode()) {
+            logger.info("{} doesn't exist, it may has been deleted.", plan.getPaths().get(i));
+          } else {
+            needThrow = true;

Review comment:
       Delete operations indeed succeed, but the client may receives a error message which
may confuse user. 
   
   I handle the exception to prevent this error message, skip all the timeseries_not_exist
exception.
   
   
   
   ![image](https://user-images.githubusercontent.com/82880298/126255831-ef30058b-b2af-4aa1-a7f4-f37dee938fef.png)
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message