iotdb-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-iotdb] SilverNarcissus commented on a change in pull request #1112: [IOTDB-354] Implement batch append entries
Date Wed, 06 May 2020 01:01:38 GMT

SilverNarcissus commented on a change in pull request #1112:
URL: https://github.com/apache/incubator-iotdb/pull/1112#discussion_r420493219



##########
File path: cluster/src/main/java/org/apache/iotdb/cluster/log/catchup/LogCatchUpTask.java
##########
@@ -39,17 +43,25 @@
 public class LogCatchUpTask implements Runnable {
 
   private static final Logger logger = LoggerFactory.getLogger(LogCatchUpTask.class);
-
-  private List<Log> logs;
+  private static final int LOG_NUM_IN_BATCH = 128;
   Node node;
   RaftMember raftMember;
+  private List<Log> logs;
+  private boolean useBatch = false;
 
   public LogCatchUpTask(List<Log> logs, Node node, RaftMember raftMember) {
     this.logs = logs;
     this.node = node;
     this.raftMember = raftMember;
   }
 
+  public LogCatchUpTask(List<Log> logs, Node node, RaftMember raftMember, boolean useBatch)
{

Review comment:
       Sure, I will fix it




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message