iotdb-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-iotdb] JulianFeinauer commented on pull request #1146: Added workaround when doing Aggregation over boolean Series.
Date Sat, 02 May 2020 07:52:24 GMT

JulianFeinauer commented on pull request #1146:
URL: https://github.com/apache/incubator-iotdb/pull/1146#issuecomment-622821366


   Makes sense I guess. Will add that
   
   Holen Sie sich Outlook für Android<https://aka.ms/ghei36>
   
   ________________________________
   From: Xiangdong Huang <notifications@github.com>
   Sent: Saturday, May 2, 2020 9:50:48 AM
   To: apache/incubator-iotdb <incubator-iotdb@noreply.github.com>
   Cc: Julian Feinauer <j.feinauer@pragmaticminds.de>; Author <author@noreply.github.com>
   Subject: Re: [apache/incubator-iotdb] Added workaround when doing Aggregation over boolean
Series. (#1146)
   
   
   @jixuan1989 commented on this pull request.
   
   ________________________________
   
   In grafana/src/main/java/org/apache/iotdb/web/grafana/dao/impl/BasicDaoImpl.java<https://github.com/apache/incubator-iotdb/pull/1146#discussion_r418927351>:
   
   >    @Override
      public List<TimeValues> querySeries(String s, Pair<ZonedDateTime, ZonedDateTime>
timeRange) {
   +    try {
   +      return querySeriesInternal(s, timeRange, function);
   +    } catch (Exception e) {
   +      logger.info("Execution failed, trying now with FIRST Function!");
   +      // Try it with FIRST
   +      try {
   +        return querySeriesInternal(s, timeRange, "FIRST");
   +      } catch (Exception e2) {
   +        logger.warn("Even FIRST query did not succeed, returning NULL now", e2);
   +        return null;
   
   
   how about empty List?
   
   —
   You are receiving this because you authored the thread.
   Reply to this email directly, view it on GitHub<https://github.com/apache/incubator-iotdb/pull/1146#pullrequestreview-404508751>,
or unsubscribe<https://github.com/notifications/unsubscribe-auth/AECOQCXTEG3FR23WPYTV7J3RPPGFRANCNFSM4MXSM3YQ>.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message