iotdb-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-iotdb] qiaojialin commented on a change in pull request #1084: [IOTDB-560] add TSRecordOutputFormat to write TsFile via Flink DataSet/DataStream API.
Date Sat, 02 May 2020 06:26:08 GMT

qiaojialin commented on a change in pull request #1084:
URL: https://github.com/apache/incubator-iotdb/pull/1084#discussion_r418919467



##########
File path: flink-tsfile-connector/README.md
##########
@@ -91,3 +91,87 @@ for (String s : result) {
 }
 ```
 
+### Example of TSRecordOutputFormat 
+
+1. create TSRecordOutputFormat with default RowTSRecordConverter.
+
+```java
+String[] filedNames = {
+	QueryConstant.RESERVED_TIME,
+	"device_1.sensor_1",
+	"device_1.sensor_2",
+	"device_1.sensor_3",
+	"device_2.sensor_1",
+	"device_2.sensor_2",
+	"device_2.sensor_3"
+};
+TypeInformation[] typeInformations = new TypeInformation[] {
+	Types.LONG,
+	Types.FLOAT,

Review comment:
       ```suggestion
   	Types.LONG,
   ```

##########
File path: flink-tsfile-connector/README.md
##########
@@ -91,3 +91,87 @@ for (String s : result) {
 }
 ```
 
+### Example of TSRecordOutputFormat 
+
+1. create TSRecordOutputFormat with default RowTSRecordConverter.
+
+```java
+String[] filedNames = {
+	QueryConstant.RESERVED_TIME,
+	"device_1.sensor_1",
+	"device_1.sensor_2",
+	"device_1.sensor_3",
+	"device_2.sensor_1",
+	"device_2.sensor_2",
+	"device_2.sensor_3"
+};
+TypeInformation[] typeInformations = new TypeInformation[] {
+	Types.LONG,
+	Types.FLOAT,
+	Types.LONG,
+	Types.LONG,
+	Types.FLOAT,

Review comment:
       ```suggestion
   	Types.LONG,
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message