iotdb-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-iotdb] wshao08 commented on a change in pull request #1136: [IOTDB-632]Performance improve for Linear Fill
Date Fri, 01 May 2020 08:50:29 GMT

wshao08 commented on a change in pull request #1136:
URL: https://github.com/apache/incubator-iotdb/pull/1136#discussion_r418466705



##########
File path: server/src/main/java/org/apache/iotdb/db/query/executor/fill/PreviousFill.java
##########
@@ -0,0 +1,117 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.iotdb.db.query.executor.fill;
+
+import org.apache.iotdb.db.engine.querycontext.QueryDataSource;
+import org.apache.iotdb.db.exception.StorageEngineException;
+import org.apache.iotdb.db.exception.query.QueryProcessException;
+import org.apache.iotdb.db.qp.physical.crud.RawDataQueryPlan;
+import org.apache.iotdb.db.query.context.QueryContext;
+import org.apache.iotdb.db.query.control.QueryResourceManager;
+import org.apache.iotdb.tsfile.file.metadata.TimeseriesMetadata;
+import org.apache.iotdb.tsfile.file.metadata.enums.TSDataType;
+import org.apache.iotdb.tsfile.read.TimeValuePair;
+import org.apache.iotdb.tsfile.read.common.Path;
+import org.apache.iotdb.tsfile.read.filter.TimeFilter;
+import org.apache.iotdb.tsfile.read.filter.basic.Filter;
+import org.apache.iotdb.tsfile.read.filter.factory.FilterFactory;
+
+import java.io.IOException;
+import java.util.*;
+
+public class PreviousFill extends IFill {
+
+  private Path seriesPath;
+  private QueryContext context;
+  private long beforeRange;
+  private Set<String> allSensors;
+  private Filter timeFilter;
+
+  private boolean untilLast;
+
+  public PreviousFill(TSDataType dataType, long queryTime, long beforeRange) {
+    this(dataType, queryTime, beforeRange, false);
+  }
+
+  public PreviousFill(long beforeRange) {
+    this(beforeRange, false);
+  }
+
+
+  public PreviousFill(long beforeRange, boolean untilLast) {
+    this.beforeRange = beforeRange;
+    this.untilLast = untilLast;
+  }
+
+
+  public PreviousFill(TSDataType dataType, long queryTime, long beforeRange, boolean untilLast)
{
+    super(dataType, queryTime);
+    this.beforeRange = beforeRange;
+    this.untilLast = untilLast;
+  }
+
+  @Override
+  public IFill copy() {
+    return new PreviousFill(dataType,  queryTime, beforeRange, untilLast);
+  }
+
+  @Override
+  void constructFilter() {
+    Filter lowerBound = beforeRange == -1 ? TimeFilter.gtEq(Long.MIN_VALUE)
+        : TimeFilter.gtEq(queryTime - beforeRange);
+    // time in [queryTime - beforeRange, queryTime]
+    timeFilter = FilterFactory.and(lowerBound, TimeFilter.ltEq(queryTime));
+  }
+
+  public long getBeforeRange() {
+    return beforeRange;
+  }
+
+  @Override
+  public void configureFill(
+      Path path, TSDataType dataType, long queryTime, Set<String> sensors, QueryContext
context) {
+    this.seriesPath = path;
+    this.dataType = dataType;
+    this.context = context;
+    this.queryTime = queryTime;
+    this.allSensors = sensors;
+    constructFilter();
+  }
+
+  @Override
+  public TimeValuePair getFillResult()
+      throws IOException, QueryProcessException, StorageEngineException {
+    QueryDataSource dataSource =
+        QueryResourceManager.getInstance().getQueryDataSource(seriesPath, context, timeFilter);
+    // update filter by TTL
+    timeFilter = dataSource.updateFilterUsingTTL(timeFilter);
+    LastPointReader lastReader = new LastPointReader(
+        seriesPath, dataType, allSensors, context, dataSource, queryTime, timeFilter);
+
+    return lastReader.getTimeseriesLastPointXXX();

Review comment:
       Oh, that's a temporary name forgot to correct.. Fixed




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



Mime
View raw message