From reviews-return-1629-archive-asf-public=cust-asf.ponee.io@iotdb.apache.org Fri May 10 09:19:27 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 36E731807C5 for ; Fri, 10 May 2019 11:19:25 +0200 (CEST) Received: (qmail 71057 invoked by uid 500); 10 May 2019 09:19:24 -0000 Mailing-List: contact reviews-help@iotdb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@iotdb.apache.org Delivered-To: mailing list reviews@iotdb.apache.org Received: (qmail 70959 invoked by uid 99); 10 May 2019 09:19:24 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 10 May 2019 09:19:24 +0000 From: GitBox To: reviews@iotdb.apache.org Subject: [GitHub] [incubator-iotdb] mdf369 commented on a change in pull request #172: Refactor iotdb code for cluster Message-ID: <155747996435.14620.7562114413395722245.gitbox@gitbox.apache.org> Date: Fri, 10 May 2019 09:19:24 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit mdf369 commented on a change in pull request #172: Refactor iotdb code for cluster URL: https://github.com/apache/incubator-iotdb/pull/172#discussion_r282807858 ########## File path: iotdb/src/main/java/org/apache/iotdb/db/service/TSServiceImpl.java ########## @@ -791,7 +834,7 @@ private TSExecuteStatementResp getTSExecuteStatementResp(TS_StatusCode code, Str return resp; } - private TSExecuteBatchStatementResp getTSBathExecuteStatementResp(TS_StatusCode code, String msg, + public TSExecuteBatchStatementResp getTSBathExecuteStatementResp(TS_StatusCode code, String msg, Review comment: why change to public? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services