From reviews-return-1612-archive-asf-public=cust-asf.ponee.io@iotdb.apache.org Thu May 9 09:52:49 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id BF2B1180649 for ; Thu, 9 May 2019 11:52:48 +0200 (CEST) Received: (qmail 98937 invoked by uid 500); 9 May 2019 09:52:48 -0000 Mailing-List: contact reviews-help@iotdb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@iotdb.apache.org Delivered-To: mailing list reviews@iotdb.apache.org Received: (qmail 98919 invoked by uid 99); 9 May 2019 09:52:48 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 May 2019 09:52:48 +0000 From: GitBox To: reviews@iotdb.apache.org Subject: [GitHub] [incubator-iotdb] fanhualta commented on issue #172: Refactor iotdb code for cluster Message-ID: <155739556794.27638.15327567243364446310.gitbox@gitbox.apache.org> Date: Thu, 09 May 2019 09:52:47 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit fanhualta commented on issue #172: Refactor iotdb code for cluster URL: https://github.com/apache/incubator-iotdb/pull/172#issuecomment-490837888 > The difference between `IQueryProcessExecutor.java` and `IEngineQueryRouter.java `? Seems they have similar interface.. I think `IQueryProcessExecutor.java` is to handle all operation, including query and non-query operation. `IEngineQueryRouter.java` is to handle all query type operation, which is called by subclass of `IQueryProcessExecutor.java`. The name also puzzle me and it's also a historical legacy of naming. And we can talk about the naming offline. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services