From reviews-return-1598-archive-asf-public=cust-asf.ponee.io@iotdb.apache.org Wed May 8 15:00:31 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 472B9180630 for ; Wed, 8 May 2019 17:00:31 +0200 (CEST) Received: (qmail 7155 invoked by uid 500); 8 May 2019 15:00:30 -0000 Mailing-List: contact reviews-help@iotdb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@iotdb.apache.org Delivered-To: mailing list reviews@iotdb.apache.org Received: (qmail 7143 invoked by uid 99); 8 May 2019 15:00:30 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 May 2019 15:00:30 +0000 From: GitBox To: reviews@iotdb.apache.org Subject: [GitHub] [incubator-iotdb] jixuan1989 commented on a change in pull request #172: Refactor iotdb code for cluster Message-ID: <155732762554.4258.5757084467519847878.gitbox@gitbox.apache.org> Date: Wed, 08 May 2019 15:00:25 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit jixuan1989 commented on a change in pull request #172: Refactor iotdb code for cluster URL: https://github.com/apache/incubator-iotdb/pull/172#discussion_r282107582 ########## File path: iotdb/src/main/java/org/apache/iotdb/db/service/TSServiceImpl.java ########## @@ -717,43 +792,10 @@ private TSExecuteStatementResp executeUpdateStatement(String statement) "Statement is a query statement."); } - // if operation belongs to add/delete/update Review comment: pls reserve this comment... and it says if the operation is add/delete/update, why you name the function as `executeUpdateStatement(physicalPlan);` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services