From reviews-return-1591-archive-asf-public=cust-asf.ponee.io@iotdb.apache.org Wed May 8 09:06:33 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 796EE180630 for ; Wed, 8 May 2019 11:06:33 +0200 (CEST) Received: (qmail 16256 invoked by uid 500); 8 May 2019 09:06:33 -0000 Mailing-List: contact reviews-help@iotdb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@iotdb.apache.org Delivered-To: mailing list reviews@iotdb.apache.org Received: (qmail 16245 invoked by uid 99); 8 May 2019 09:06:32 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 May 2019 09:06:32 +0000 From: GitBox To: reviews@iotdb.apache.org Subject: [GitHub] [incubator-iotdb] jixuan1989 commented on a change in pull request #172: Refactor iotdb code for cluster Message-ID: <155730639281.23535.4740943666207725302.gitbox@gitbox.apache.org> Date: Wed, 08 May 2019 09:06:32 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit jixuan1989 commented on a change in pull request #172: Refactor iotdb code for cluster URL: https://github.com/apache/incubator-iotdb/pull/172#discussion_r281978499 ########## File path: iotdb/src/main/java/org/apache/iotdb/db/qp/executor/IQueryProcessExecutor.java ########## @@ -0,0 +1,143 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iotdb.db.qp.executor; + +import java.io.IOException; +import java.util.List; +import java.util.Map; +import org.apache.iotdb.db.exception.FileNodeManagerException; +import org.apache.iotdb.db.exception.PathErrorException; +import org.apache.iotdb.db.exception.ProcessorException; +import org.apache.iotdb.db.qp.physical.PhysicalPlan; +import org.apache.iotdb.db.qp.physical.crud.QueryPlan; +import org.apache.iotdb.db.query.context.QueryContext; +import org.apache.iotdb.db.query.executor.IEngineQueryRouter; +import org.apache.iotdb.db.query.fill.IFill; +import org.apache.iotdb.tsfile.exception.filter.QueryFilterOptimizationException; +import org.apache.iotdb.tsfile.file.metadata.enums.TSDataType; +import org.apache.iotdb.tsfile.read.common.Path; +import org.apache.iotdb.tsfile.read.expression.IExpression; +import org.apache.iotdb.tsfile.read.query.dataset.QueryDataSet; +import org.apache.iotdb.tsfile.utils.Pair; + +public interface IQueryProcessExecutor { + + boolean processNonQuery(PhysicalPlan plan) throws ProcessorException; Review comment: add javadoc, what NonQuery refers to? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services