From reviews-return-1583-archive-asf-public=cust-asf.ponee.io@iotdb.apache.org Tue May 7 10:23:48 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 5E73418064C for ; Tue, 7 May 2019 12:23:48 +0200 (CEST) Received: (qmail 46181 invoked by uid 500); 7 May 2019 10:23:47 -0000 Mailing-List: contact reviews-help@iotdb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@iotdb.apache.org Delivered-To: mailing list reviews@iotdb.apache.org Received: (qmail 46162 invoked by uid 99); 7 May 2019 10:23:47 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 07 May 2019 10:23:47 +0000 From: GitBox To: reviews@iotdb.apache.org Subject: [GitHub] [incubator-iotdb] fanhualta commented on a change in pull request #152: Cluster read Message-ID: <155722462758.11742.16452832147614079491.gitbox@gitbox.apache.org> Date: Tue, 07 May 2019 10:23:47 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit fanhualta commented on a change in pull request #152: Cluster read URL: https://github.com/apache/incubator-iotdb/pull/152#discussion_r281566643 ########## File path: cluster/src/main/java/org/apache/iotdb/cluster/query/dataset/ClusterDataSetWithTimeGenerator.java ########## @@ -0,0 +1,142 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iotdb.cluster.query.dataset; + +import java.io.IOException; +import java.util.ArrayList; +import java.util.Iterator; +import java.util.List; +import org.apache.iotdb.cluster.config.ClusterConstant; +import org.apache.iotdb.cluster.exception.RaftConnectionException; +import org.apache.iotdb.cluster.query.manager.coordinatornode.ClusterRpcSingleQueryManager; +import org.apache.iotdb.cluster.query.timegenerator.ClusterTimeGenerator; +import org.apache.iotdb.db.query.reader.merge.EngineReaderByTimeStamp; +import org.apache.iotdb.tsfile.file.metadata.enums.TSDataType; +import org.apache.iotdb.tsfile.read.common.Field; +import org.apache.iotdb.tsfile.read.common.Path; +import org.apache.iotdb.tsfile.read.common.RowRecord; +import org.apache.iotdb.tsfile.read.query.dataset.QueryDataSet; + +/** + * Dataset with time generator for cluster + */ +public class ClusterDataSetWithTimeGenerator extends QueryDataSet { + + private ClusterRpcSingleQueryManager queryManager; + private ClusterTimeGenerator timeGenerator; + private List readers; Review comment: Good advice, accept. fixed. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services