iotdb-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-iotdb] mdf369 commented on a change in pull request #172: Refactor iotdb code for cluster
Date Fri, 10 May 2019 09:19:24 GMT
mdf369 commented on a change in pull request #172: Refactor iotdb code for cluster
URL: https://github.com/apache/incubator-iotdb/pull/172#discussion_r282807905
 
 

 ##########
 File path: iotdb/src/main/java/org/apache/iotdb/db/service/TSServiceImpl.java
 ##########
 @@ -810,14 +853,22 @@ private TSFetchResultsResp getTSFetchResultsResp(TS_StatusCode code,
String msg)
   }
 
   public void handleClientExit() throws TException {
+    closeClusterService();
     closeOperation(null);
     closeSession(null);
   }
 
+  /**
+   * Close cluster service
+   */
+  public void closeClusterService() {
 
 Review comment:
   Why add this empty method?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message