iotdb-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-iotdb] mdf369 commented on a change in pull request #172: Refactor iotdb code for cluster
Date Fri, 10 May 2019 09:19:24 GMT
mdf369 commented on a change in pull request #172: Refactor iotdb code for cluster
URL: https://github.com/apache/incubator-iotdb/pull/172#discussion_r282807853
 
 

 ##########
 File path: iotdb/src/main/java/org/apache/iotdb/db/service/TSServiceImpl.java
 ##########
 @@ -766,19 +809,19 @@ private void recordANewQuery(String statement, PhysicalPlan physicalPlan)
{
    *
    * @return true: If logined; false: If not logined
    */
-  private boolean checkLogin() {
+  public boolean checkLogin() {
     return username.get() != null;
   }
 
-  private boolean checkAuthorization(List<Path> paths, PhysicalPlan plan) throws AuthException
{
+  public boolean checkAuthorization(List<Path> paths, PhysicalPlan plan) throws AuthException
{
     String targetUser = null;
     if (plan instanceof AuthorPlan) {
       targetUser = ((AuthorPlan) plan).getUserName();
     }
     return AuthorityChecker.check(username.get(), paths, plan.getOperatorType(), targetUser);
   }
 
-  private TSExecuteStatementResp getTSExecuteStatementResp(TS_StatusCode code, String msg)
{
+  public TSExecuteStatementResp getTSExecuteStatementResp(TS_StatusCode code, String msg)
{
 
 Review comment:
   why change to public?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message