iotdb-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-iotdb] mdf369 commented on a change in pull request #172: Refactor iotdb code for cluster
Date Fri, 10 May 2019 09:19:24 GMT
mdf369 commented on a change in pull request #172: Refactor iotdb code for cluster
URL: https://github.com/apache/incubator-iotdb/pull/172#discussion_r282805000
 
 

 ##########
 File path: iotdb/src/main/java/org/apache/iotdb/db/service/TSServiceImpl.java
 ##########
 @@ -627,26 +693,31 @@ public TSFetchResultsResp fetchResults(TSFetchResultsReq req) throws
TException
     }
   }
 
-  private QueryDataSet createNewDataSet(String statement, int fetchSize, TSFetchResultsReq
req)
+  public QueryDataSet createNewDataSet(String statement, int fetchSize, TSFetchResultsReq
req)
 
 Review comment:
   why change to `public`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message