iotdb-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-iotdb] mdf369 commented on a change in pull request #172: Refactor iotdb code for cluster
Date Fri, 10 May 2019 09:19:23 GMT
mdf369 commented on a change in pull request #172: Refactor iotdb code for cluster
URL: https://github.com/apache/incubator-iotdb/pull/172#discussion_r282804062
 
 

 ##########
 File path: iotdb/src/main/java/org/apache/iotdb/db/service/TSServiceImpl.java
 ##########
 @@ -359,14 +366,43 @@ public TSFetchMetadataResp fetchMetadata(TSFetchMetadataReq req) throws
TExcepti
     return resp;
   }
 
+  protected Set<String> getAllStorageGroups() throws PathErrorException, InterruptedException
{
+    return MManager.getInstance().getAllStorageGroup();
+  }
+
+  protected List<List<String>> getTimeSeriesForPath(String path)
+      throws PathErrorException, InterruptedException, ProcessorException {
+    return MManager.getInstance().getShowTimeseriesPath(path);
+  }
+
+  protected String getMetadataInString()
+      throws InterruptedException, PathErrorException, ProcessorException {
+    return MManager.getInstance().getMetadataInString();
+  }
+
+  protected Metadata getMetadata()
+      throws PathErrorException, InterruptedException, ProcessorException {
+    return MManager.getInstance().getMetadata();
+  }
+
+  protected TSDataType getSeriesType(String path)
+      throws PathErrorException, InterruptedException, ProcessorException {
+    return MManager.getInstance().getSeriesType(path);
+  }
+
+  protected List<String> getPaths(String path)
+      throws PathErrorException, InterruptedException, ProcessorException {
+    return MManager.getInstance().getPaths(path);
+  }
+
   /**
-   * Judge whether the statement is ADMIN COMMAND and if true, executeWithGlobalTimeFilter
it.
+   * Judge whether the statement is ADMIN COMMAND and if true, execute it.
    *
    * @param statement command
    * @return true if the statement is ADMIN COMMAND
    * @throws IOException exception
    */
-  private boolean execAdminCommand(String statement) throws IOException {
+  public boolean execAdminCommand(String statement) throws IOException {
 
 Review comment:
   why change to `public`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message