iotdb-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-iotdb] jt2594838 commented on a change in pull request #172: Refactor iotdb code for cluster
Date Fri, 10 May 2019 06:11:19 GMT
jt2594838 commented on a change in pull request #172: Refactor iotdb code for cluster
URL: https://github.com/apache/incubator-iotdb/pull/172#discussion_r282756125
 
 

 ##########
 File path: iotdb/src/main/java/org/apache/iotdb/db/service/TSServiceImpl.java
 ##########
 @@ -488,6 +533,22 @@ public TSExecuteStatementResp executeStatement(TSExecuteStatementReq
req) throws
     }
   }
 
+  /**
+   * Set consistency level
+   */
+  public boolean execSetConsistencyLevel(String statement) throws Exception {
+    if (statement == null) {
 
 Review comment:
   Maybe it is more straight-forward to just throw an exception and tell the user that this
operation is illegal.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message