iotdb-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-iotdb] fanhualta commented on a change in pull request #172: Refactor iotdb code for cluster
Date Thu, 09 May 2019 09:14:59 GMT
fanhualta commented on a change in pull request #172: Refactor iotdb code for cluster
URL: https://github.com/apache/incubator-iotdb/pull/172#discussion_r282402423
 
 

 ##########
 File path: iotdb/src/main/java/org/apache/iotdb/db/service/TSServiceImpl.java
 ##########
 @@ -717,43 +792,10 @@ private TSExecuteStatementResp executeUpdateStatement(String statement)
           "Statement is a query statement.");
     }
 
-    // if operation belongs to add/delete/update
 
 Review comment:
   ok, add this comment already. I change those codes in `executeUpdateStatement(statement)`
to `executeUpdateStatement(physicalPlan)` because these code are exactly same and duplicate.
 Name  `executeUpdateStatement ` is a historical legacy of naming, not something I have changed.
 `executeUpdateStatement` process non-query operation´╝î including add/delete/delete.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message