iotdb-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-iotdb] jixuan1989 commented on a change in pull request #172: Refactor iotdb code for cluster
Date Wed, 08 May 2019 15:00:25 GMT
jixuan1989 commented on a change in pull request #172: Refactor iotdb code for cluster
URL: https://github.com/apache/incubator-iotdb/pull/172#discussion_r282107582
 
 

 ##########
 File path: iotdb/src/main/java/org/apache/iotdb/db/service/TSServiceImpl.java
 ##########
 @@ -717,43 +792,10 @@ private TSExecuteStatementResp executeUpdateStatement(String statement)
           "Statement is a query statement.");
     }
 
-    // if operation belongs to add/delete/update
 
 Review comment:
   pls reserve this comment... and it says if the operation is add/delete/update, why you
name the function as `executeUpdateStatement(physicalPlan);`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message