iotdb-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-iotdb] fanhualta commented on a change in pull request #152: Cluster read
Date Tue, 07 May 2019 08:58:11 GMT
fanhualta commented on a change in pull request #152: Cluster read
URL: https://github.com/apache/incubator-iotdb/pull/152#discussion_r281534913
 
 

 ##########
 File path: cluster/src/main/java/org/apache/iotdb/cluster/service/TSServiceClusterImpl.java
 ##########
 @@ -53,17 +66,50 @@
 
   private static final Logger LOGGER = LoggerFactory.getLogger(TSServiceClusterImpl.class);
 
-  private ThreadLocal<NonQueryExecutor> nonQueryExecutor = new ThreadLocal<>();
-  private ThreadLocal<QueryMetadataExecutor> queryMetadataExecutor = new ThreadLocal<>();
+  private ClusterQueryProcessExecutor queryDataExecutor = new ClusterQueryProcessExecutor();
 
 Review comment:
   It's unnecessary to make `NonQueryExecutor` and `QueryMetadataExecutor` be ThreadLocal.
Only some fields in the class need to be ThreadLocal, it will waste resource to do like before.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message