iotdb-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-iotdb] mdf369 commented on a change in pull request #152: Cluster read
Date Mon, 06 May 2019 07:01:56 GMT
mdf369 commented on a change in pull request #152: Cluster read
URL: https://github.com/apache/incubator-iotdb/pull/152#discussion_r281001933
 
 

 ##########
 File path: cluster/src/main/java/org/apache/iotdb/cluster/qp/executor/NonQueryExecutor.java
 ##########
 @@ -358,9 +361,9 @@ public boolean handleNonQueryRequestLocally(String groupId, QPTask qpTask)
    * @param leader leader of the target raft group
    * @return request result
    */
-  public boolean asyncHandleNonQueryTask(QPTask task, PeerId leader)
+  public boolean asyncHandleNonQueryTask(SingleQPTask task, PeerId leader)
 
 Review comment:
   Is it for sure that only SingleQPTask will be send to this method?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message