Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id CE596200CD2 for ; Thu, 13 Jul 2017 00:28:47 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id CCB6F169FF3; Wed, 12 Jul 2017 22:28:47 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 1E70E169FEC for ; Thu, 13 Jul 2017 00:28:46 +0200 (CEST) Received: (qmail 73117 invoked by uid 500); 12 Jul 2017 22:28:46 -0000 Mailing-List: contact commits-help@iota.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@iota.incubator.apache.org Delivered-To: mailing list commits@iota.incubator.apache.org Received: (qmail 73091 invoked by uid 99); 12 Jul 2017 22:28:44 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 12 Jul 2017 22:28:44 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id E198F195836 for ; Wed, 12 Jul 2017 22:28:43 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.021 X-Spam-Level: X-Spam-Status: No, score=-4.021 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id TTqUy7L87k5R for ; Wed, 12 Jul 2017 22:28:43 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id A75116270C for ; Wed, 12 Jul 2017 22:09:32 +0000 (UTC) Received: (qmail 42249 invoked by uid 99); 12 Jul 2017 22:09:31 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 12 Jul 2017 22:09:31 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 26241EEE19; Wed, 12 Jul 2017 22:09:30 +0000 (UTC) From: cristofolini To: commits@iota.incubator.apache.org Reply-To: commits@iota.incubator.apache.org References: In-Reply-To: Subject: [GitHub] incubator-iota issue #35: IOTA-41: Spring dependency injection for fey perfo... Content-Type: text/plain Message-Id: <20170712220931.26241EEE19@git1-us-west.apache.org> Date: Wed, 12 Jul 2017 22:09:30 +0000 (UTC) archived-at: Wed, 12 Jul 2017 22:28:48 -0000 Github user cristofolini commented on the issue: https://github.com/apache/incubator-iota/pull/35 @barbaragomes I've added a couple unit tests, one to check that a context is loaded and one to check that a factory is instatiated. I want to get some feedback on two things: - Am I doing this right? I'm completely new to Scala and these are the first tests I ever coded (in Scala, anyway) and mostly based myself on the other tests that are implemented; - Anything else that needs testing? Let me know if there's anything else I should cover. @rafaelweingartner I've changed the autowiring method to by_type. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---