iota-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cristofolini <...@git.apache.org>
Subject [GitHub] incubator-iota pull request #35: IOTA 41: Spring dependency injection for fe...
Date Thu, 06 Jul 2017 17:17:31 GMT
GitHub user cristofolini opened a pull request:

    https://github.com/apache/incubator-iota/pull/35

    IOTA 41: Spring dependency injection for fey performers

    Our proposed implementation consists of creating a class that extends the original FeyGenericActor
(named FeyGenericSpringActor), which allows for one more argument to be passed within its
constructor, which is a String containing a path for the XML file containing that actor's
Spring context, which can be an absolute or relative filesystem path (relative to the current
VM working directory) or obtained from the classpath (by specifying a "classpath:" prefix);
other protocols and prefixes may be supported by the Spring framework. The new actor class
has two attributes: an ApplicationContext and its AutowireCapableBeanFactory, which will allow
us to instantiate the beans specified in the actor's context.
    
    Other modifications to the fey engine core include the necessary changes related to parsing
the orchestration JSON: adding an entry for the actor context's file path on the JSON validator
and parser method, along with a conditional check to see if a path to the actor's context
was specified in the JSON, so that fey will instantiate a FeyGenericSpringActor instead of
a FeyGenericActor.
    
    Lastly, we've created a FeyApplicationContext.xml, which should be the parent context
to all actor contexts created, and will contain useful universal declarations. For now, all
it does is enable annotation usage in all Spring actors.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cristofolini/incubator-iota master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-iota/pull/35.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #35
    
----
commit 8c1a715090b4b8eb357b5b0bd095a12a1c03f771
Author: Lucas Berri Cristofolini <lucas@autonomiccs.com.br>
Date:   2017-07-06T17:10:07Z

    Added a new actor type capable of using the Spring framework

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message