iota-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From cristofolini <...@git.apache.org>
Subject [GitHub] incubator-iota issue #35: IOTA-41: Spring dependency injection for fey perfo...
Date Wed, 12 Jul 2017 22:09:30 GMT
Github user cristofolini commented on the issue:

    https://github.com/apache/incubator-iota/pull/35
  
    @barbaragomes I've added a couple unit tests, one to check that a context is loaded and
one to check that a factory is instatiated. I want to get some feedback on two things: 
    
    - Am I doing this right? I'm completely new to Scala and these are the first tests I ever
coded (in Scala, anyway) and mostly based myself on the other tests that are implemented;
    
    - Anything else that needs testing? Let me know if there's anything else I should cover.
    
    @rafaelweingartner I've changed the autowiring method to by_type.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message