iota-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From barbaragomes <...@git.apache.org>
Subject [GitHub] incubator-iota issue #24: [IOTA-29] Removed the scalastyle Warnings
Date Tue, 15 Nov 2016 00:22:43 GMT
Github user barbaragomes commented on the issue:

    https://github.com/apache/incubator-iota/pull/24
  
    Hey @shiv4nsh, before we can merge this PR would you mind implementing the items bellow?
    
    1. File: **fey-core/src/main/scala/org/apache/iota/fey/Ensemble.scala**
    ```
    val performerInfo = performers_metadata.getOrElse(performerID, null)
     -      if(performerInfo != null){
     +      if (Option(performerInfo).isDefined) {
    ```
    Instead of creating an Option after the getOrElse please call **.get(performerID)**, this
way the performerInfo is of type Option. (Make sure all the other implications are resolved
as well)
    2. File: **fey-core/src/main/scala/org/apache/iota/fey/FeyGenericActor.scala**
    ```
    if (Option(scheduler).isDefined) 
    ```
    Define global variable scheduler as of type Option and make all of the other necessary
changes.
    3. File: **fey-core/src/main/scala/org/apache/iota/fey/Monitor.scala**
    ```
    +    if(Option(reason).isDefined){
    ```
    Define parameter reason as of type Option[Throwable] and make the necessary changes
    4. File: **fey-core/src/main/scala/org/apache/iota/fey/TrieNode.scala**
    ```
    (Option(root).isDefined)
    ```
    Define variable root as of type Option and make the necessary changes 
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message