infra-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (INFRA-18763) Please set core.autocrlf = true for Windows-based build machines
Date Thu, 08 Aug 2019 14:29:00 GMT

    [ https://issues.apache.org/jira/browse/INFRA-18763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16903028#comment-16903028
] 

ASF subversion and git services commented on INFRA-18763:
---------------------------------------------------------

Commit 1083ebe2e8bcfacfb6b8c5135e13b4cc11b414e6 in infrastructure-puppet's branch refs/heads/deployment
from dfoulks1
[ https://gitbox.apache.org/repos/asf?p=infrastructure-puppet.git;h=1083ebe ]

Merge pull request #1620 from apache/christ/INFRA-18763

reverting change of autocrlf as per INFRA-18763

> Please set core.autocrlf = true for Windows-based build machines
> ----------------------------------------------------------------
>
>                 Key: INFRA-18763
>                 URL: https://issues.apache.org/jira/browse/INFRA-18763
>             Project: Infrastructure
>          Issue Type: Bug
>          Components: Jenkins
>            Reporter: Vladimir Sitnikov
>            Assignee: Chris Thistlethwaite
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Please:
> 1) Revert https://issues.apache.org/jira/browse/INFRA-18383 (== set core.autocrlf=true)
> 2) Add a comment that core.autocrlf = true must not be changed later, but if someone
is having CRLF/LF issues, they should use .gitattributes file in their own repositories to
make the configuration consistent across all checkouts.
> Background:
> 0) GitHub recommends to configure core.autocrlf=true for Windows: https://help.github.com/en/articles/configuring-git-to-handle-line-endings
> 1) Typically, Windows uses CRLF for line endings. In other words, "regular text editors"
use CRLF for Windows 
> 2) Git has no preference to CRLF or LF. It could adhere to whatever user wants. Of course,
Git can be configured to keep files as "binary" (which means do not convert between CRLF/LF)

> 3) It is in line with SVN settings, and it is in line with what ASF recommends for SVN:
https://www.apache.org/dev/svn-eol-style.txt
> So the proper approach is as follows: 
> 1) Windows-based host should have core.autocrlf=true. That would tell Git that **text**
files should be converted to CRLF unless otherwise specified (by .gitattributes file)
> 2) If certain files in the repository must have LF even at Windows checkout, then .gitattributes
should be used to specify that



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Mime
View raw message