infra-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Gruno (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (INFRA-18554) Github mails don't always include change diffs
Date Sun, 02 Jun 2019 22:34:00 GMT

    [ https://issues.apache.org/jira/browse/INFRA-18554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16854132#comment-16854132
] 

Daniel Gruno commented on INFRA-18554:
--------------------------------------

That is unfortunate, I had hoped we had found a fix for these black box merges. I'll raise
the issue with the team and see if/where we can add a fix for this. It should not be happening,
but part of it is due to how GitHub handles PRs from forks, wherein the code is silently injected
into our repository before merge, but we never see that injection and so multimail thinks
the code has always been there and does not make a diff for the new code.

> Github mails don't always include change diffs
> ----------------------------------------------
>
>                 Key: INFRA-18554
>                 URL: https://issues.apache.org/jira/browse/INFRA-18554
>             Project: Infrastructure
>          Issue Type: Bug
>          Components: Github
>            Reporter: Sebb
>            Assignee: Daniel Gruno
>            Priority: Major
>
> Changes to ASF repos made via GitHub don't always show the commit diff.
> For example, the following commit [1]  on May 30th should appear as a diff on commits@logging.a.o.
However it does not appear to be there [2].
> This makes it impossible to perform CTR from the mailing list as is the case for SVN
updates.
> If the code cannot be fixed to show the diffs in the emails, then perhaps at least the
email could be amended to include links to the changes so the reader can review changes without
needing to trawl the Git repo.
> [1] https://github.com/apache/logging-log4j-audit/commit/b4da24faa2e7a498ec690009c606ae3234342148
> [2] https://lists.apache.org/list.html?commits@logging.apache.org:dfr=2019-05-30|dto=2019-05-31



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message