infra-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <>
Subject [jira] [Commented] (INFRA-9250) Self serve does not allow empty attributes to be populated
Date Thu, 21 Mar 2019 02:28:00 GMT


ASF subversion and git services commented on INFRA-9250:

Commit 68de71601d952a8ffadec86a1f082d7bab1d6575 in infrastructure-puppet's branch refs/heads/deployment
from clambertus
[;h=68de716 ]

Revert "INFRA-9250"

> Self serve does not allow empty attributes to be populated
> ----------------------------------------------------------
>                 Key: INFRA-9250
>                 URL:
>             Project: Infrastructure
>          Issue Type: Planned Work
>      Security Level: public(Regular issues) 
>          Components: Identity Management
>            Reporter: Sebb
>            Assignee: Chris Lambertus
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: Mar 2016
>          Time Spent: 20m
>  Remaining Estimate: 0h
> The self-serve app does not allow empty attributes to be populated.
> This is because of lines 258/259 in [1], where the field is set to disabled if the attribute
is not present in the values for the current record.
> A simple fix is to remove the lines.
> However, this then causes a problem, because empty fields are pre-populated with the
value "<not present>", which will get written to the attribute if the user does not
clear the fields first. This would be tedious and error-prone.
> Dropping the "<not present>" value does not work either, because the field is currently
only rendered if there is a value for it.
> The changedetails.html template needs to show at least one field for every supported
attribute whether it has an actual value or not.  
> For writable fields, one could use a field placeholder attribute [2] to show the "<not
present>" text. This would also be suitable for read-only fields.
> Whatever approach is taken, there needs to be a way to test the changes.
> Is there a test installation of the SelfServe app that can be used to check that the
page renders OK?
> [1]
> [2]

This message was sent by Atlassian JIRA

View raw message