infra-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (INFRA-9250) Self serve does not allow empty attributes to be populated
Date Thu, 14 Mar 2019 02:09:00 GMT

    [ https://issues.apache.org/jira/browse/INFRA-9250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16792255#comment-16792255
] 

ASF GitHub Bot commented on INFRA-9250:
---------------------------------------

cthistle commented on pull request #1475: INFRA-9250
URL: https://github.com/apache/infrastructure-puppet/pull/1475
 
 
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Self serve does not allow empty attributes to be populated
> ----------------------------------------------------------
>
>                 Key: INFRA-9250
>                 URL: https://issues.apache.org/jira/browse/INFRA-9250
>             Project: Infrastructure
>          Issue Type: Planned Work
>      Security Level: public(Regular issues) 
>          Components: Identity Management
>            Reporter: Sebb
>            Assignee: Chris Lambertus
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: Mar 2016
>
>
> The self-serve app does not allow empty attributes to be populated.
> This is because of lines 258/259 in [1], where the field is set to disabled if the attribute
is not present in the values for the current record.
> A simple fix is to remove the lines.
> However, this then causes a problem, because empty fields are pre-populated with the
value "<not present>", which will get written to the attribute if the user does not
clear the fields first. This would be tedious and error-prone.
> Dropping the "<not present>" value does not work either, because the field is currently
only rendered if there is a value for it.
> The changedetails.html template needs to show at least one field for every supported
attribute whether it has an actual value or not.  
> For writable fields, one could use a field placeholder attribute [2] to show the "<not
present>" text. This would also be suitable for read-only fields.
> Whatever approach is taken, there needs to be a way to test the changes.
> Is there a test installation of the SelfServe app that can be used to check that the
page renders OK?
>  
> [1] https://svn.apache.org/repos/infra/infrastructure/selfserve/trunk/lib/selfserve/__init__.py
> [2] http://www.w3schools.com/tags/att_input_placeholder.asp



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message