infra-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Gruno (JIRA)" <>
Subject [jira] [Resolved] (INFRA-17679) ECharts protect branch on GitHub
Date Thu, 17 Jan 2019 08:37:00 GMT


Daniel Gruno resolved INFRA-17679.
    Resolution: Fixed

All set up. I will note that there is a technical/policy-related chance that this could be
revoked, should someone wish to work on echarts and not use github. We do not enforce people's
choice of github versus gitbox.

> ECharts protect branch on GitHub
> --------------------------------
>                 Key: INFRA-17679
>                 URL:
>             Project: Infrastructure
>          Issue Type: Task
>          Components: Github
>            Reporter: Ovilia
>            Assignee: Daniel Gruno
>            Priority: Major
>   Original Estimate: 10m
>  Remaining Estimate: 10m
> Since we are going to have new committers from the community, after some discussion,
we would like to protect some branches (master, release, and protected-*) so that everyone
should not push to those branches directly. Instead, one should push to a temporary branch
and create a PR to have it merged.
> Please help do the following settings:
> 1. In project branches page
, click *add rule*.
> 2. In *Apply rule to*, fill in master.
> 3. Check *Require pull request reviews before merging*. Make sure *Required approing
reviews* is 1.
> 4. Check *Dismiss stale pull request approvals when new commits are pushed*.
> 5. Check *Include administrators*
> 6. Click *Save changes*
> Then, go back to and create
two more rules, with the same settings, but a different *Apply rule to* value, namely, release
and protected-*.
> Thanks!

This message was sent by Atlassian JIRA

View raw message