infra-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Jumper (JIRA)" <j...@apache.org>
Subject [jira] [Created] (INFRA-17642) Formatting/content of merge email mildly incorrect
Date Sun, 13 Jan 2019 22:08:00 GMT
Michael Jumper created INFRA-17642:
--------------------------------------

             Summary: Formatting/content of merge email mildly incorrect
                 Key: INFRA-17642
                 URL: https://issues.apache.org/jira/browse/INFRA-17642
             Project: Infrastructure
          Issue Type: Bug
          Components: GitBox
            Reporter: Michael Jumper


When a pull request is merged, an email like the following is sent out to dev@:

>
> necouchman closed pull request #356: GUACAMOLE-699: Add helper script for verifying translations.
> URL: https://github.com/apache/guacamole-client/pull/356
>
>
>
>
> This is a PR merged from a forked repository.
> As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
>
> As this is a foreign pull request (from a fork), the diff has been
sent to your commit mailing list, commits@guacamole.apache.org
>

This is not entirely correct as:

1. "closing" a pull request is distinct from "merging" a pull request. If a pull request is
merged rather than closed without being merged, the message should probably state that it
was merged.

2. The message states the diff "is displayed below for the sake of provenance", but then corrects
itself to note that the diff is not displayed below but has been sent to commits@.

I suggest simply stating that the pull request has been merged, giving the summary of that
merge as is already done here, and mentioning that the diff has been sent to commits@.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message