infra-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Gruno (JIRA)" <>
Subject [jira] [Updated] (INFRA-17642) Formatting/content of merge email mildly incorrect
Date Mon, 14 Jan 2019 06:52:00 GMT


Daniel Gruno updated INFRA-17642:
    Status: Waiting for user  (was: Waiting for Infra)

I've simplified things now, and changed it to "foo merged pull request 1234" when a merge
is detected. It should also only do one line of "this is a fork merge, bla bla see ML" instead
of the previous two. Lemme know how it looks :)

> Formatting/content of merge email mildly incorrect
> --------------------------------------------------
>                 Key: INFRA-17642
>                 URL:
>             Project: Infrastructure
>          Issue Type: Bug
>          Components: GitBox
>            Reporter: Michael Jumper
>            Assignee: Daniel Gruno
>            Priority: Minor
> When a pull request is merged, an email like the following is sent out to dev@:
> >
> > necouchman closed pull request #356: GUACAMOLE-699: Add helper script for verifying
> > URL:
> >
> >
> >
> >
> > This is a PR merged from a forked repository.
> > As GitHub hides the original diff on merge, it is displayed below for
> the sake of provenance:
> >
> > As this is a foreign pull request (from a fork), the diff has been
> sent to your commit mailing list,
> >
> This is not entirely correct as:
> 1. "closing" a pull request is distinct from "merging" a pull request. If a pull request
is merged rather than closed without being merged, the message should probably state that
it was merged.
> 2. The message states the diff "is displayed below for the sake of provenance", but then
corrects itself to note that the diff is not displayed below but has been sent to commits@.
> I suggest simply stating that the pull request has been merged, giving the summary of
that merge as is already done here, and mentioning that the diff has been sent to commits@.

This message was sent by Atlassian JIRA

View raw message