infra-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Duo Zhang (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (INFRA-16532) force pushes against master branch of HBase repo should be disallowed
Date Thu, 31 May 2018 03:05:00 GMT

    [ https://issues.apache.org/jira/browse/INFRA-16532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496015#comment-16496015
] 

Duo Zhang edited comment on INFRA-16532 at 5/31/18 3:04 AM:
------------------------------------------------------------

There is no specific commit I'd say. The story is that I accidentally pushed HBASE-19064 to
master(I have rebased the branch so this is not a force push and it was succeeded), and then
I did a force push and reverted the master back. The commit d2daada970b424263533517d2a26e36e31ec2746
was the old head of master.

commit d2daada970b424263533517d2a26e36e31ec2746
Author: Zach York <zyork@amazon.com>
Date:   Wed Mar 21 15:37:09 2018 -0700

    HBASE-20447 Only fail cacheBlock if block collisions aren't related to next block metadata
    
    When we pread, we don't force the read to read all of the next block header.
    However, when we get into a race condition where two opener threads try to
    cache the same block and one thread read all of the next block header and
    the other one didn't, it will fail the open process. This is especially important
    in a splitting case where it will potentially fail the split process.
    Instead, in the caches, we should only fail if the required blocks are different.
    
    Signed-off-by: Andrew Purtell <apurtell@apache.org>


was (Author: apache9):
There is no specific commit I'd say. The story is that I accidentally pushed HBASE-19064 to
master(I have rebased the branch so this is not a force push and it was succeeded), and then
I did a force push and reverted the master back. The commit d2daada970b424263533517d2a26e36e31ec2746
was the old head of master.

{noformat}
commit d2daada970b424263533517d2a26e36e31ec2746
Author: Zach York <zyork@amazon.com>
Date:   Wed Mar 21 15:37:09 2018 -0700

    HBASE-20447 Only fail cacheBlock if block collisions aren't related to next block metadata
    
    When we pread, we don't force the read to read all of the next block header.
    However, when we get into a race condition where two opener threads try to
    cache the same block and one thread read all of the next block header and
    the other one didn't, it will fail the open process. This is especially important
    in a splitting case where it will potentially fail the split process.
    Instead, in the caches, we should only fail if the required blocks are different.
    
    Signed-off-by: Andrew Purtell <apurtell@apache.org>
{noformat}

> force pushes against master branch of HBase repo should be disallowed
> ---------------------------------------------------------------------
>
>                 Key: INFRA-16532
>                 URL: https://issues.apache.org/jira/browse/INFRA-16532
>             Project: Infrastructure
>          Issue Type: Bug
>          Components: Git
>            Reporter: Sean Busbey
>            Priority: Critical
>
> HBase's git repo isn't supposed to allow force pushes to master (ref INFRA-12602), but
one went through earlier today:
> https://lists.apache.org/thread.html/bc5b5c47e936255877c3efc5de0f316f8d0e35469f891f06148b0e7e@%3Ccommits.hbase.apache.org%3E
> Is there a way for me to check which refs are protected?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message