infra-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hoss Man (JIRA)" <>
Subject [jira] [Commented] (INFRA-16094) Please change text on JIRA "Submit Patch" button to "Submit issue for automated Patch Review" OSLT (but probably shorter, I mean seriously, it's a button ffs)
Date Tue, 01 May 2018 18:07:00 GMT


Hoss Man commented on INFRA-16094:

Chris wrote: "This is going to be a considerable amount of infra effort" .. in response to
Gavin's suggestion that "it is likley what we really want is your own special little workflow
for your two projects" -- But that wasn't actually what was requested originally.  

> For now, we will keep this low priority, and maybe a simpler solution will present itself.

What was originally requested *was* a very simple solution: Improve the text of the buttons
(for all jira projects using this workflow) to be clear what they do.

As I understand it, that should be a trivial amount of effort, and the only concern i've seen
raised regarding that suggestion is "This change will affect hundreds of projects" w/o any
response to my comment that the effect seems like a general improvement for all projects,
and should be trivial to revert in the unlikely event any one actually complains that the
button text becomes more clear.

Please: If i'm being obtuse as to some reason why fixing the text of these buttons to accurately
describe what they do would be problematic/hard then let me know I'm happy to drop it -- but
i'm honestly boggled by the push back on this.  

It's like saying "Hey can you please fix this pot hole." and the response is "100s of people
drive on that street who would be affected by us fixing it, and none of them have ever complained
about that pothole, so it sounds like you need your own new street which would be a huge undertaking,
so no -- we'll just leave this request open indenfinitely and prioritize it at the bottom
of the list" 

(the only diff i can see is that fixing a pothole might actually inconvenience some people
for a short amount of time while the work is done, or it might be had to "undo" the pothole
fix if people complain that the pothole was their favorite fishing spot ... change these button
texts should take no time, have no downtime, and be trivial to revert it anyone complains.)

> Please change text on JIRA "Submit Patch" button to "Submit issue for automated Patch
Review" OSLT (but probably shorter, I mean seriously, it's a button ffs)
> --------------------------------------------------------------------------------------------------------------------------------------------------------------
>                 Key: INFRA-16094
>                 URL:
>             Project: Infrastructure
>          Issue Type: Bug
>          Components: JIRA
>            Reporter: Steve Rowe
>            Assignee: Chris Lambertus
>            Priority: Major
> LUCENE & SOLR projects recently switched to the workflow required for Yetus integration
(see INFRA-15213 ).  Committers are now asking that the text on the "Submit Patch" button
be changed to something more reflective of what it really does, i.e. change issue status (rather
than having anything to do with uploading patches).  
> From
> -----
> can we *PLEASE* rename the "Submit Patch" button to something else since it does not
actually give you the power to "submit a patch" -- ie: clicking that button does nothing to
enable me to upload a patch file from my computer.  that functionality is burried in the "More"
menu as "Attach Files"
> AFAICT the _true_ functionality of the current button is "Submit issue for automated
Patch Review" -- so can we please change the button text to say that?  Likewise i would suggest
changing the "Cancel Patch" button to something like "Cancel Automated Patch Review"
> (If it's _also_ possible to add a top level button that *actually* triggers the "Attach
Files" file selector, then by all means let's do that and give it text like "Submit Patch"
or "Attach New Path")
> -----

This message was sent by Atlassian JIRA

View raw message