infra-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (INFRA-12876) rebuild configscanner.py
Date Sat, 05 May 2018 23:20:00 GMT

    [ https://issues.apache.org/jira/browse/INFRA-12876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16464934#comment-16464934
] 

Sebb commented on INFRA-12876:
------------------------------

How about:
- get current revision of workspace (old)
- update to new revision as per the pubsub message (svn update -r new)
- if fails, restore previous revision (svn update -r old)

So long as the process is single-threaded, I don't see an issue with this.

If configscanner.py is not single-threaded, then the existing processing is also at risk of
a race condition.
Seems to me it's a worse risk, as there are lots of commands involved.

> rebuild configscanner.py
> ------------------------
>
>                 Key: INFRA-12876
>                 URL: https://issues.apache.org/jira/browse/INFRA-12876
>             Project: Infrastructure
>          Issue Type: Planned Work
>          Components: Buildbot
>            Reporter: Greg Stein
>            Assignee: Greg Stein
>            Priority: Minor
>
> First, infrastructure-puppet/modules/buildbot_asf/files/configscanner.py uses custom
code to talk to the pubsub hub. This should switch to Apache Subversion's client code for
that: svnsubpub.client
> Second, it has some janky code for detecting new files and attempting to create them.
The "svn cat" fails because it attempts to use a local working copy reference for a file that
doesn't exist. It should use a URL, where the file will exist. (the failure means that, due
to the shell redirect, a 0 byte file is created which then causes an "svn update" failure
due to a file conflict)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message