infra-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gavin (JIRA)" <>
Subject [jira] [Commented] (INFRA-16286) [mail-private] bugs in
Date Tue, 03 Apr 2018 10:55:00 GMT


Gavin commented on INFRA-16286:

Sure, much of this is carry over from thor aka mail-search. Most of these tickets I see you
filing are as improvements to what was on mail-search. Im currently making sure the migration
takes place and thor gets turned off. Feel free to create patches, but nothing in this ticket
is specific to mail-private, quite a bit of what you are reporting is whats been in place
on thor, not saying it is right, and sure, it needs to be fixed as 'an improvement' to the
current system, but this will not hold up the migration.

> [mail-private] bugs in
> ---------------------------------------
>                 Key: INFRA-16286
>                 URL:
>             Project: Infrastructure
>          Issue Type: Bug
>          Components: Mail Archives
>            Reporter: Sebb
>            Priority: Major
> The script has various bugs.
> 1) It uses system("umask ...").
> AFAICT that is useless, as the setting only applies to the sub-process.
> 2) It runs 'chmod -R' on the whole mbox tree each time.
> That seems wasteful.
> 3) There is no protection against running the script concurrently.
> It relies on the script completing before the next invocation by cron.
> (Currently hourly)
> 4) If an instance of mbox-util takes too long (currently 3600 seconds = 1hr) it writes
a message to stdout, which is thrown away by the cronjob.
> It does not try to stop the process.

This message was sent by Atlassian JIRA

View raw message