infra-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hoss Man (JIRA)" <>
Subject [jira] [Commented] (INFRA-16094) Please change text on JIRA "Submit Patch" button to "Submit issue for automated Patch Review" OSLT (but probably shorter, I mean seriously, it's a button ffs)
Date Mon, 30 Apr 2018 18:55:00 GMT


Hoss Man commented on INFRA-16094:

I'm confused ... this may impact lots of projects, but isn't he impact for the better?  

Changing the label on the buttons won't break anything for any project, correct? just make
it more clear what these buttons do?

Why is that a bad thing?

It may not have come up in the past if projects used this workflow from Day 1, but it seemed
*REALLY* jarring for us because where there use to be an "Attach Files" button (in the old
jira version) there is now a "Submit Patch" button that brings you up an Edit issue form w/o
any place to submit/attach anything!

That's an incredibly frustrating UI experience -- both for people who are familiar with the
old workflow -- but also for any brand new user/contributor who may not know anything about
yetus/jira-workflows at all (and who may not know/care enough about ASF infra to have any
idea how to bring up their confusion)

Just because no one else using this workflow has complained about the button labels before
doesn't mean they wouldn't consider it an improvement to fix those labels to be accurate ...
particularly since it's a trivial change that would be trivial to un-change if there was in
fact some sort of huge backlash of existing workflow users that find "[Enable Auto Patch Review]"
to be some sort of huge inconvenience compared to the currently confusing "[Submit Patch]"

> Please change text on JIRA "Submit Patch" button to "Submit issue for automated Patch
Review" OSLT (but probably shorter, I mean seriously, it's a button ffs)
> --------------------------------------------------------------------------------------------------------------------------------------------------------------
>                 Key: INFRA-16094
>                 URL:
>             Project: Infrastructure
>          Issue Type: Bug
>          Components: JIRA
>            Reporter: Steve Rowe
>            Assignee: Chris Lambertus
>            Priority: Major
> LUCENE & SOLR projects recently switched to the workflow required for Yetus integration
(see INFRA-15213 ).  Committers are now asking that the text on the "Submit Patch" button
be changed to something more reflective of what it really does, i.e. change issue status (rather
than having anything to do with uploading patches).  
> From
> -----
> can we *PLEASE* rename the "Submit Patch" button to something else since it does not
actually give you the power to "submit a patch" -- ie: clicking that button does nothing to
enable me to upload a patch file from my computer.  that functionality is burried in the "More"
menu as "Attach Files"
> AFAICT the _true_ functionality of the current button is "Submit issue for automated
Patch Review" -- so can we please change the button text to say that?  Likewise i would suggest
changing the "Cancel Patch" button to something like "Cancel Automated Patch Review"
> (If it's _also_ possible to add a top level button that *actually* triggers the "Attach
Files" file selector, then by all means let's do that and give it text like "Submit Patch"
or "Attach New Path")
> -----

This message was sent by Atlassian JIRA

View raw message