infra-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steve Rowe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (INFRA-16094) Please change text on JIRA "Submit Patch" button to "Submit issue for automated Patch Review" OSLT (but probably shorter, I mean seriously, it's a button ffs)
Date Fri, 23 Feb 2018 23:20:00 GMT

    [ https://issues.apache.org/jira/browse/INFRA-16094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16375105#comment-16375105
] 

Steve Rowe commented on INFRA-16094:
------------------------------------

I'm surprised that it hasn't come up in the past... the only reason I can think of is that
Lucene/Solr have been active for a long time, and people are used to the old JIRA workflow,
so this change was jarring.  Maybe other projects instituted the workflow earlier in their
history?

If you think it's not appropriate for other projects, because it would be intrusive/unwanted/whatever,
then sure, I think it's worth making a special little workflow for just LUCENE and SOLR.

My suggestions for the button names: [Enable Auto Patch Review] and [Disable Auto Patch Review].

> Please change text on JIRA "Submit Patch" button to "Submit issue for automated Patch
Review" OSLT (but probably shorter, I mean seriously, it's a button ffs)
> --------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: INFRA-16094
>                 URL: https://issues.apache.org/jira/browse/INFRA-16094
>             Project: Infrastructure
>          Issue Type: Bug
>          Components: JIRA
>            Reporter: Steve Rowe
>            Priority: Major
>
> LUCENE & SOLR projects recently switched to the workflow required for Yetus integration
(see INFRA-15213 ).  Committers are now asking that the text on the "Submit Patch" button
be changed to something more reflective of what it really does, i.e. change issue status (rather
than having anything to do with uploading patches).  
> From  https://issues.apache.org/jira/browse/SOLR-10912?focusedCommentId=16374760&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16374760
:
> -----
> can we *PLEASE* rename the "Submit Patch" button to something else since it does not
actually give you the power to "submit a patch" -- ie: clicking that button does nothing to
enable me to upload a patch file from my computer.  that functionality is burried in the "More"
menu as "Attach Files"
> AFAICT the _true_ functionality of the current button is "Submit issue for automated
Patch Review" -- so can we please change the button text to say that?  Likewise i would suggest
changing the "Cancel Patch" button to something like "Cancel Automated Patch Review"
> (If it's _also_ possible to add a top level button that *actually* triggers the "Attach
Files" file selector, then by all means let's do that and give it text like "Submit Patch"
or "Attach New Path")
> -----



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message