infra-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Carlos Santana (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (INFRA-14158) Configure github settings for protected branch OpenWhisk
Date Mon, 15 May 2017 21:44:04 GMT

     [ https://issues.apache.org/jira/browse/INFRA-14158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Carlos Santana resolved INFRA-14158.
------------------------------------
    Resolution: Fixed

Thanks [~pono] what you did fixed the problem !

> Configure github settings for protected branch OpenWhisk
> --------------------------------------------------------
>
>                 Key: INFRA-14158
>                 URL: https://issues.apache.org/jira/browse/INFRA-14158
>             Project: Infrastructure
>          Issue Type: Task
>          Components: Github
>            Reporter: Carlos Santana
>            Assignee: Daniel Takamori
>
> The github repo needs to be configure with protected branch for master.
> But the settings for the protected should be as follow
> - Check "Protect this branch"
> - Check "Require pull request reviews before merging"
>     - UnCheck "Dismiss stale pull requests approvals..."
>     - UnCheck "Restrict who can dismiss pull requests reviews"
> - Check "Require status checks to pass before merging"
>     - UnCheck "Require branches to be up to date before merging"
> - UnCheck "Restrict who can push to this branch"
> - UnCheck "Include administrators"
> I think the repo is configured this way, and I think the only setting to change is to
Un-check the box "Require branches to be up to date before merging" since we have Travis we
are confortable with this settings since we inspect visually and then rely on Travis build
if the merge cause problems, we will get notify.
> -- Carlos



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message