infra-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (INFRA-13772) ASFBot meeting log issues
Date Tue, 28 Mar 2017 20:53:42 GMT

    [ https://issues.apache.org/jira/browse/INFRA-13772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15945946#comment-15945946
] 

Sebb commented on INFRA-13772:
------------------------------

Multipart issue can be fixed as per the docs [3]

{code}
Index: plugins/meetings.py
===================================================================
--- plugins/meetings.py	(revision 1009248)
+++ plugins/meetings.py	(working copy)
@@ -214,7 +214,7 @@
                     return
                 sock.say(channel, "Sending email summary...")
                 try:
-                    msg = MIMEMultipart()
+                    msg = MIMEMultipart('alternative')
                     msg['Subject'] = "Summary of IRC Meeting in %s" % channel
                     msg['From'] = 'ASF IRC Bot <asfbot@wilderness.apache.org>'
                     msg['To'] = dat
{code}

[3] https://docs.python.org/2/library/email-examples.html#id3

> ASFBot meeting log issues
> -------------------------
>
>                 Key: INFRA-13772
>                 URL: https://issues.apache.org/jira/browse/INFRA-13772
>             Project: Infrastructure
>          Issue Type: Project
>          Components: Other/Misc
>            Reporter: Sebb
>
> The ASFBot does not show its replies in the meeting summary.
> So for example, the quorum replies are not shown. [1]
> Also, the mail includes two copies of the log: plain text and HTML. [2]
> Not sure what benefit the HTML copy is, but assuming it is needed, the sections should
be added as multipart alternatives [3] so mail clients such as GMail only show one copy.
> Note: the HTML copy does not show up in [1]
> [1] https://lists.apache.org/thread.html/4e4776929fc744f70abeb010fb5d3570f91b264abc1887e9e86009e9@%3Cmembers.apache.org%3E
> [2] https://mail-search.apache.org/members/private-arch/members/201703.mbox/raw/%3c20170328183150.2892F31C30@wilderness.apache.org%3e
> [3] https://www.w3.org/Protocols/rfc1341/7_2_Multipart.html



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message