infra-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gavin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (INFRA-9705) Remove elementid Markdown extension
Date Thu, 02 Jul 2015 08:27:04 GMT

    [ https://issues.apache.org/jira/browse/INFRA-9705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14611652#comment-14611652
] 

Gavin commented on INFRA-9705:
------------------------------

Note that I'm not phasing our or dropping anything. I was just applying patches and asking
to check if they are working.
Yesterday something in one of sebbs patches stopped the markdownd from working so those were
reverted.
Then I applied patches from much older tickets from Steve Rowe (as you suggested) (INFRA-8578
and INFRA-8576)
It is INFRA-8576 patch that (re)applied the elementid by the looks of things (so sebbs assumption
it wasnt there is correct, until it got put back by the patch yesterday.)
Also note that the loca lwc on the cms is inline with svn and no local changes.


> Remove elementid Markdown extension
> -----------------------------------
>
>                 Key: INFRA-9705
>                 URL: https://issues.apache.org/jira/browse/INFRA-9705
>             Project: Infrastructure
>          Issue Type: Bug
>          Components: CMS, Website
>         Environment: https://svn.apache.org/repos/infra/websites/cms/build/mdx_elementid.py
> https://svn.apache.org/repos/infra/websites/cms/build/markdownd.py
>            Reporter: Sebb
>         Attachments: INFRA-9705.patch, diff, diff2, diff3, diff_final
>
>
> The elementid Markdown extension appears to have been originally intended to handle Special
Attributes as per PHP Markdown Extras [1]. However it was not a complete implementation.
> The elementid extension code was later extended to try to handle permalinks as per Subversion
[2]. However it turned out that this code interfered with TOC processing.
> It would of course be possible to fix both of these issues, however there seems little
point as the Python Markdown module includes atttribute lists [3] as well as permalinks [4].
> I think it therefore makes sense to disable elementid by removing it from markdownd.py:EXTENSIONS.
> Attribute lists and permalinks can then be enabled separately; see related JIRAs.
> [1] https://michelf.ca/projects/php-markdown/extra/#spe-attr
> [2] http://subversion.apache.org/style/site.css
> [3] https://pythonhosted.org/Markdown/extensions/attr_list.html
> [4] https://pythonhosted.org/Markdown/extensions/toc.html#usage



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message