infra-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Avery Ching (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (INFRA-5046) Apache Giraph reviewboard not working correctly
Date Tue, 14 Aug 2012 07:46:38 GMT

    [ https://issues.apache.org/jira/browse/INFRA-5046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13433975#comment-13433975
] 

Avery Ching commented on INFRA-5046:
------------------------------------

Gavin, thanks again for all your help!  There are still a few issues with reviewboard that
we could really use your help on.  Please let us know if you are not the right person to contact.

1) Reviewboard used to automatically post to the relevant JIRA based on the "Bugs: entry".
 For instance, https://reviews.apache.org/r/6600/ should have posted to https://issues.apache.org/jira/browse/GIRAPH-300.
 This no longer happens.

2) I am still getting moderate reviews for every reviewboard posting.  Have you seen this
for other projects?  It seemed to also have occurred after the move out of the incubator.
 Would really appreciate your help with this one as well.

Here is an example below:

Subject:
MODERATE for dev@giraph.apache.org
From:
dev-reject-1344929528.87753.oellomidngbomiepblpl@giraph.apache.org
Date:
8/14/12 12:32 AM
To:
Recipient list not shown: ;
CC:
dev-allow-tc.1344929528.hlcimadaieekbgjlgmpo-noreply=reviews.apache.org@giraph.apache.org


To approve:
   dev-accept-1344929528.87753.oellomidngbomiepblpl@giraph.apache.org
To reject:
   dev-reject-1344929528.87753.oellomidngbomiepblpl@giraph.apache.org
To give a reason to reject:
%%% Start comment
%%% End comment


ForwardedMessage.eml
Subject:
Review Request: GIRAPH-300 : Improve netty reliability with retrying failed connections, tracking
requests, thread-safe hash partitioning
From:
"Avery Ching" <avery.ching@gmail.com>
Date:
8/14/12 12:32 AM
To:
"Avery Ching" <avery.ching@gmail.com>, "giraph" <dev@giraph.apache.org>

This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6600/

Review request for giraph.
By Avery Ching.
Description

* Upgrade to the most recent stable version of Netty (3.5.3.Final)
* Try multiple connection attempts up to n failures
* Track requests throughout the system by keeping track of the request id and then matching
the request id to the response (minor refactoring of WritableRequest to make requests simpler
and support the request id)
* Improved handling of netty exceptions by dumping the exception stack to help debug failures
* Fixes bug in HashWorkerPartitioner by making partitionList thread-safe (this causes divide
by zero exceptions in real life)

Testing

Currently, netty connection failures causes issues with more than 75 workers in my setup.
This allows us to reach over 200+ in a reasonably reliable network that doesn't kill connections.

This code passes the local Hadoop regressions and the single node Hadoop instance regressions.
It also succeeded on large runs (200+ workers) on a real Hadoop cluster.

Bugs: GIRAPH-300
Diffs

    http://svn.apache.org/repos/asf/giraph/trunk/pom.xml (1372575)
    http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/comm/NettyClient.java
(1372575)
    http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/comm/NettyServer.java
(1372575)
    http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/comm/NettyWorkerClient.java
(1372575)
    http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/comm/RequestInfo.java
(PRE-CREATION)
    http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/comm/RequestServerHandler.java
(1372575)
    http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/comm/ResponseClientHandler.java
(1372575)
    http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/comm/SendPartitionMessagesRequest.java
(1372575)
    http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/comm/SendPartitionMutationsRequest.java
(1372575)
    http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/comm/SendVertexRequest.java
(1372575)
    http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/comm/WritableRequest.java
(1372575)
    http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/graph/BspServiceMaster.java
(1372575)
    http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/graph/GiraphJob.java
(1372575)
    http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/graph/partition/HashWorkerPartitioner.java
(1372575)
    http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/utils/TimedLogger.java
(1372575)
    http://svn.apache.org/repos/asf/giraph/trunk/src/test/java/org/apache/giraph/comm/ConnectionTest.java
(1372575)

View Diff

Attachments:
ForwardedMessage.eml	10.3 KB
                
> Apache Giraph reviewboard not working correctly
> -----------------------------------------------
>
>                 Key: INFRA-5046
>                 URL: https://issues.apache.org/jira/browse/INFRA-5046
>             Project: Infrastructure
>          Issue Type: Task
>      Security Level: public(Regular issues) 
>            Reporter: Avery Ching
>
> Apache Giraph used to be in the incubator until 5/2012.
> For reviewboard 
> base directory:  http://svn.apache.org/repos/asf/incubator/giraph/trunk
> used to work with submitting reviews.  Now, after the move, we try to use
> base directory: http://svn.apache.org/repos/asf/giraph/trunk
> and it will fail on the first file in the diff, although the file exists:
> i.e. 
> The file 'http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PseudoRandomVertexInputFormat.java'
(r1356104) could not be found in the repository
> We can see that the file actually exists 
> http://svn.apache.org/repos/asf/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PseudoRandomVertexInputFormat.java
> and that the revision exists as well.
> http://svn.apache.org/viewvc/giraph/trunk/src/main/java/org/apache/giraph/benchmark/PseudoRandomVertexInputFormat.java?view=log
> Can you please help us?  After the move to TLP, we havn't been able to submit reviews.
 Thanks!!!

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message