incubator-zeta-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jérôme Renard <jerome.ren...@gmail.com>
Subject [zeta-dev] Re: Review Request: Session timeout
Date Thu, 16 Jun 2011 04:55:49 GMT


> On 2011-06-15 12:11:33, james pic wrote:
> > trunk/Authentication/src/session/authentication_session.php, line 136
> > <https://reviews.apache.org/r/783/diff/1/?file=19578#file19578line136>
> >
> >     why not use a local variable for that ? would it make the code more readable
and easier to debug ?

A local variable for time() ? If yes, then you are right, I will fix this.


- Jérôme


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/783/#review844
-----------------------------------------------------------


On 2011-05-25 08:23:39, Jérôme Renard wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/783/
> -----------------------------------------------------------
> 
> (Updated 2011-05-25 08:23:39)
> 
> 
> Review request for zetacomponents.
> 
> 
> Summary
> -------
> 
> Added a new ezcAuthenticationSessionOptions::idleTimeOut option to handle user's inactivity.
> 
> 
> This addresses bug ZETACOMP-81.
>     https://issues.apache.org/jira/browse/ZETACOMP-81
> 
> 
> Diffs
> -----
> 
>   trunk/Authentication/src/options/session_options.php 1125639 
>   trunk/Authentication/src/session/authentication_session.php 1125639 
>   trunk/Authentication/tests/session/session_test.php 1125639 
> 
> Diff: https://reviews.apache.org/r/783/diff
> 
> 
> Testing
> -------
> 
> Added two new unit tests :
> - ezcAuthenticationSessionTest::testSessionIsValidIdleTimeout()
> - ezcAuthenticationSessionTest::testSessionIsValidIdleTimeoutExpired()
> 
> php ./UnitTest/src/runtests.php --filter=ezcAuthenticationSessionTest --verbose Authentication
> PHPUnit 3.5.10 by Sebastian Bergmann.
> 
> Zeta Components:                        
> 
>   Authentication:                       
>     ezcAuthenticationGeneralTest:       
>     ezcAuthenticationSessionTest:       ............
> [...]
> 
> 
> Thanks,
> 
> Jérôme
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message