incubator-zeta-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tobias Schlitt <tob...@schlitt.info>
Subject Re: [zeta-dev] Bug with Webdav + Bugfix
Date Wed, 30 Mar 2011 20:10:18 GMT
Hi Jerome,

On 03/30/2011 10:00 PM, Jerome Renard wrote:

> On Wed, Mar 30, 2011 at 5:55 PM, Tobias Schlitt <tobias@schlitt.info> wrote:

>> The idea of your fix looks generally correct to me. However, we cannot
>> simply change the content of the request body, since it would break BC.
>> Instead we basically have 2 choices for implementing handling of large
>> files:
>>
>> 1. Adding an option to switch on stream based body handling.
>> 2. Abstracting body extraction into a dedicated object to allow
>> dependency injection for handling of large bodies.
>>
>> I'm not yet sure, which way to go. We should discuss this on the list.

> Option #1 should be enough I think. This idea of using a stream is really
> interesting. I hardly see any use case for option #2 actually.

I think we should actually do a mixture, like setting a "body extractor"
object in the options, which defaults to setting the body as the
veriable contents.

Regards,
Toby


-- 
Tobias Schlitt        http://schlitt.info        GPG Key: 0xC462BC14
Want to hire me? Need quality assurance?            http://qafoo.com
eZ Components are Zeta Components now!          http://bit.ly/9S7zbn

Mime
View raw message