incubator-zeta-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Derick Rethans <der...@apache.org>
Subject Re: [zeta-dev] Patch: Fix for dependent tests in Template
Date Mon, 24 Jan 2011 14:04:44 GMT
On Mon, 24 Jan 2011, Tobias Schlitt wrote:

> On 01/24/2011 11:18 AM, Derick Rethans wrote:
> > On Sun, 23 Jan 2011, Tobias Schlitt wrote:
> 
> >> I discovered an issue with dependent tests in Template and provided 
> >> a patch for it in [1]. My fix introduces a new method on 
> >> ezcTemplateConfiguration in order to be able to set a fresh 
> >> configuration instance for every test case.
> >>
> >> Please review the patch and give me feedback if the solution is OK 
> >> to you.
> 
> > I am not really happy with this, but I always hated the singleton 
> > template configuration as well. The correct way would be to get rid 
> > of the singleton crap here all together, but in the meanwhile this 
> > works as a good workaround.
> 
> I fully agree with you about the static dependency. However, getting 
> rid of it without breaking BC is pretty hard.
> 
> I'm going to commit my patch so that we can ship around it in tests. 
> The new method does not really hurt and can maybe even be of use for 
> users.

I would suggest to mark it with @access private; as I would not 
recommend using this!

cheers,
Derick

Mime
View raw message