incubator-yoko-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Lars Kühne (JIRA) <j...@apache.org>
Subject [jira] Commented: (YOKO-385) IDLPreProcessor doesn't handle comments
Date Thu, 12 Jul 2007 19:40:04 GMT

    [ https://issues.apache.org/jira/browse/YOKO-385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12512230
] 

Lars Kühne commented on YOKO-385:
---------------------------------

Balaji, I don't see how svn commit #547690 can possibly have fixed this issue. I can't see
any commit related to the same line vs new line problem you mention in your comment. Did you
close this issue by mistake?

Also, do you have a unit test for your fix? I just played around with gcc a bit, the gcc preprocessor
correctly transforms this

-- snip --
#define metoo ", i want that, too :-/*" /* :-// */
#ifndef /* defined a */ askdad
#define ask "mom" // or should it be "mum"?
#else // yeah, we know who is more likely to say yes :-)
#define ask "dad" /* "dear dad" would yield even better results. */
#endif /* ho,
good we got through this tricky preprocessor stuff.
*/
char* iwant = ask + metoo;
-- snip --

into the following line plus a few location markers:

char* iwant = "mom" + ", i want that, too :-/*";

Probably something like this should be included in the preprocessor unit tests, together with
corner cases like incorrect preprocessor directives like "#elsee", which I think were broken
by your commit.

> IDLPreProcessor doesn't handle comments
> ---------------------------------------
>
>                 Key: YOKO-385
>                 URL: https://issues.apache.org/jira/browse/YOKO-385
>             Project: Yoko - CORBA Server
>          Issue Type: Bug
>    Affects Versions: v1.0.0
>            Reporter: Balaji Ravi
>            Assignee: Balaji Ravi
>             Fix For: v1.0.0
>
>
> When an idl has /* comments the idl parser fails because the preprocessor doesn't handle
them. Also, then check for #endif doesn;t take in to account comments after #end if on the
same line.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message