incubator-yoko-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anders Hessellund Jensen <...@trifork.com>
Subject Re: [jira] Closed: (YOKO-33) RMI/IIOP implementation
Date Tue, 11 Jul 2006 12:19:51 GMT
Daniel Kulp wrote:
> Umm.... should a jira issue be marked closed if there are no unit tests?   
> Without tests, how do you know the jira is really fixed/closed?
> 
> At the very least, a new jira issue should be opened to track the fact that 
> tests are completely missing.   However, I would say the original jira issue 
> remains open until test coverage is "satisfactory".  (definition open to 
> interpretation)    Basically, add a comment saying "source patch applied, 
> unit tests required" or similar.

Yes, you are absolutely right.

There are some testing of the code however. The RMITest in the core 
module can be used with either Suns implementation of ValueHandler or 
the one i just committed.  I am going to set it up to use the latter.

The current test is rather high-level, however, and I would like to add 
some more fine-grained tests, since that would make errors much easier 
to diagnose.

I would like to add the rmi module as a component in JIRA.

Best regards,
Anders

Mime
View raw message