incubator-yoko-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mosur Ravi, Balaji" <br...@iona.com>
Subject RE: [jira] Reopened: (YOKO-63) Test cases failing in the yoko core module
Date Thu, 15 Jun 2006 19:00:14 GMT
There are some well defined rules that have been defined in checkstyle
for writing java code.

http://checkstyle.sourceforge.net/

For eg: No tabs in the code, indenting at the proper level, imports
appearing in an order, etc...

Some of the rules might be a bit too much, but they provide an option
for us to decide which rules we want to apply for our project...

The tools module does style checking using these rules & it makes it
much easier to read the code...

That said I understand that the core module has a lot of files & it
would take forever to do proper formatting of them to comply with these
rules...

- Balaji

-----Original Message-----
From: Alan D. Cabrera [mailto:list@toolazydogs.com] 
Sent: Thursday, June 15, 2006 2:49 PM
To: yoko-dev@incubator.apache.org
Subject: Re: [jira] Reopened: (YOKO-63) Test cases failing in the yoko
core module

Mosur Ravi, Balaji wrote:
> I should have been clearer... 
>
> Dan pointed out these classes can be made abstract so that they don't
> get run by maven. But the problem is that these classes are being
> directly instantiated by other test cases as well as extended...
>
> So I cannot just make them abstract unless I change all the other test
> cases not to directly use them. In my opinion, the whole test suite
> needs a revisit.
>   

Thanks.  That clears it up for me.  We should file a jira issues for the

housecleaning that needs to be done.

> Also, as a side note, can we have follow proper checkstyle formatting
in
> the test classes also...? I find a lot of tabs & incorrect indentation
> when going through these tests...
>   

What's "proper checkstyle formatting"?


Regards,
Alan





Mime
View raw message