incubator-xap-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jmarga...@apache.org
Subject svn commit: r615393 - in /incubator/xap/trunk/codebase/src/xap/bridges/dojo: CellBridge.js TabBridge.js
Date Fri, 25 Jan 2008 23:16:50 GMT
Author: jmargaris
Date: Fri Jan 25 15:16:49 2008
New Revision: 615393

URL: http://svn.apache.org/viewvc?rev=615393&view=rev
Log:
https://issues.apache.org/jira/browse/XAP-562

Modified:
    incubator/xap/trunk/codebase/src/xap/bridges/dojo/CellBridge.js
    incubator/xap/trunk/codebase/src/xap/bridges/dojo/TabBridge.js

Modified: incubator/xap/trunk/codebase/src/xap/bridges/dojo/CellBridge.js
URL: http://svn.apache.org/viewvc/incubator/xap/trunk/codebase/src/xap/bridges/dojo/CellBridge.js?rev=615393&r1=615392&r2=615393&view=diff
==============================================================================
--- incubator/xap/trunk/codebase/src/xap/bridges/dojo/CellBridge.js (original)
+++ incubator/xap/trunk/codebase/src/xap/bridges/dojo/CellBridge.js Fri Jan 25 15:16:49 2008
@@ -33,7 +33,8 @@
 
 xap.bridges.dojo.CellBridge.prototype.obtainPeer = function() {
 	this._image = document.createElement("img");
-	this._image.style.visibility = 'hidden';
+	//this._image.style.visibility = 'hidden';
+	this._image.style.display = 'none';
 	this._text = document.createTextNode("");
 	this._domNode = document.createElement("span");
 	this._domNode.appendChild(this._image);
@@ -71,10 +72,10 @@
 xap.bridges.dojo.CellBridge.prototype.setImageAttribute = function(url) {
 	if(url) {
 		this._image.src = url;
-		this._image.style.visibility = 'visible';
+		this._image.style.display = '';
 	} else {
 		this._image.src = '';
-		this._image.style.visibility = 'hidden';
+		this._image.style.display = 'none';
 	}
 }
 

Modified: incubator/xap/trunk/codebase/src/xap/bridges/dojo/TabBridge.js
URL: http://svn.apache.org/viewvc/incubator/xap/trunk/codebase/src/xap/bridges/dojo/TabBridge.js?rev=615393&r1=615392&r2=615393&view=diff
==============================================================================
--- incubator/xap/trunk/codebase/src/xap/bridges/dojo/TabBridge.js (original)
+++ incubator/xap/trunk/codebase/src/xap/bridges/dojo/TabBridge.js Fri Jan 25 15:16:49 2008
@@ -75,19 +75,15 @@
 	if(this.getPeer().imageSrc) {
 		this._imageNode.src = this.getPeer().imageSrc;
 	} else {
-		this._imageNode.style.visibility = "hidden";
+		this._imageNode.style.display = 'none';
 	}
 	
 	if(this.getPeer().imageWidth) {
 		this._imageNode.style.width = this.getPeer().imageWidth;
-	} else {
-		this._imageNode.style.width  = "1px"
 	}
 	
 	if(this.getPeer().imageHeight) {
 		this._imageNode.style.height = this.getPeer().imageHeight;
-	} else {
-		this._imageNode.style.height = "1px"
 	}
 
 	// add the image to the tab	
@@ -150,6 +146,7 @@
 xap.bridges.dojo.TabBridge.prototype.setImageAttribute = function(value) {
 	if(this._imageNode) {
 		this._imageNode.src = value;
+		this._imageNode.style.display = (value) ? '' : 'none';
 	} else {
 		this.getPeer().imageSrc = value;
 	}



Mime
View raw message