incubator-xap-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jmarga...@apache.org
Subject svn commit: r583611 - /incubator/xap/trunk/codebase/src/xap/bridges/xap/XapComboBoxBridge.js
Date Wed, 10 Oct 2007 20:56:15 GMT
Author: jmargaris
Date: Wed Oct 10 13:56:14 2007
New Revision: 583611

URL: http://svn.apache.org/viewvc?rev=583611&view=rev
Log:
only call revalue if needed, only select items on
add of listItem not delete

Modified:
    incubator/xap/trunk/codebase/src/xap/bridges/xap/XapComboBoxBridge.js

Modified: incubator/xap/trunk/codebase/src/xap/bridges/xap/XapComboBoxBridge.js
URL: http://svn.apache.org/viewvc/incubator/xap/trunk/codebase/src/xap/bridges/xap/XapComboBoxBridge.js?rev=583611&r1=583610&r2=583611&view=diff
==============================================================================
--- incubator/xap/trunk/codebase/src/xap/bridges/xap/XapComboBoxBridge.js (original)
+++ incubator/xap/trunk/codebase/src/xap/bridges/xap/XapComboBoxBridge.js Wed Oct 10 13:56:14
2007
@@ -79,7 +79,6 @@
 		dojo.event.disconnect(this._childHandler,"onMouseUp",this,"onMouseUp") ;
 		dojo.event.disconnect(this._childHandler,"childAdded",this,"listboxAddedOrRemovedChild")
;
 		dojo.event.disconnect(this._childHandler,"revalue",this,"revalue") ;
-		dojo.event.disconnect(this._childHandler,"removeChild",this,"listboxAddedOrRemovedChild")
;
 	}
 
 	childHandler.setIsChildOfComboBox(true);
@@ -98,8 +97,6 @@
 	dojo.event.connect(this._childHandler,"onKeyDown",this,"onKeyDown") ;
 	dojo.event.connect(this._childHandler,"onMouseUp",this,"onMouseUp") ;
 	dojo.event.connect(childHandler,"childAdded",this,"listboxAddedOrRemovedChild") ;
-	dojo.event.connect(childHandler,"removeChild",this,"listboxAddedOrRemovedChild") ;
-
 	dojo.event.connect(childHandler,"revalue",this,"revalue") ;
 
 }
@@ -114,9 +111,8 @@
 	// there is none such yet, choose the first one by default:
 	if( select.selectedIndex == -1 && select.options.length > 0 ){
 		select.selectedIndex = 0 ;
+		this.revalue() ;
 	}
-
-	this.revalue() ;
 }
 
 xap.bridges.xap.XapComboBoxBridge.prototype.revalue = function(){



Mime
View raw message