From xap-commits-return-1083-apmail-incubator-xap-commits-archive=incubator.apache.org@incubator.apache.org Tue Jan 30 03:04:48 2007 Return-Path: Delivered-To: apmail-incubator-xap-commits-archive@locus.apache.org Received: (qmail 23290 invoked from network); 30 Jan 2007 03:04:48 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 30 Jan 2007 03:04:48 -0000 Received: (qmail 57742 invoked by uid 500); 30 Jan 2007 03:04:54 -0000 Delivered-To: apmail-incubator-xap-commits-archive@incubator.apache.org Received: (qmail 57719 invoked by uid 500); 30 Jan 2007 03:04:54 -0000 Mailing-List: contact xap-commits-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: xap-dev@incubator.apache.org Delivered-To: mailing list xap-commits@incubator.apache.org Received: (qmail 57710 invoked by uid 99); 30 Jan 2007 03:04:54 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 29 Jan 2007 19:04:54 -0800 X-ASF-Spam-Status: No, hits=-9.4 required=10.0 tests=ALL_TRUSTED,NO_REAL_NAME X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO eris.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 29 Jan 2007 19:04:47 -0800 Received: by eris.apache.org (Postfix, from userid 65534) id 0B6981A981A; Mon, 29 Jan 2007 19:04:26 -0800 (PST) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r501299 - /incubator/xap/trunk/codebase/src/xap/session/DeclarativeArgumentParser.js Date: Tue, 30 Jan 2007 03:04:26 -0000 To: xap-commits@incubator.apache.org From: jmargaris@apache.org X-Mailer: svnmailer-1.1.0 Message-Id: <20070130030427.0B6981A981A@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: jmargaris Date: Mon Jan 29 19:04:22 2007 New Revision: 501299 URL: http://svn.apache.org/viewvc?view=rev&rev=501299 Log: removed some logging that happened even when logging was off making things way slow Modified: incubator/xap/trunk/codebase/src/xap/session/DeclarativeArgumentParser.js Modified: incubator/xap/trunk/codebase/src/xap/session/DeclarativeArgumentParser.js URL: http://svn.apache.org/viewvc/incubator/xap/trunk/codebase/src/xap/session/DeclarativeArgumentParser.js?view=diff&rev=501299&r1=501298&r2=501299 ============================================================================== --- incubator/xap/trunk/codebase/src/xap/session/DeclarativeArgumentParser.js (original) +++ incubator/xap/trunk/codebase/src/xap/session/DeclarativeArgumentParser.js Mon Jan 29 19:04:22 2007 @@ -344,10 +344,12 @@ //why do we do +1 here? because if the last terminating character //was , we need to start our search one AFTER the comma! var result = this.parseArgument(argumentsString,argumentStart+1,sourceElement, clientEvent); - xap.session.DeclarativeArgumentParser.s_log.debug("Got back result " + result._resultObject); + if (xap.util.LogFactory.s_loggingEnabled) + xap.session.DeclarativeArgumentParser.s_log.debug("Got back result " + result._resultObject); if (result._resultObject!=null){ args.push(result._resultObject); - xap.session.DeclarativeArgumentParser.s_log.debug("Push result: " + result._resultObject); + if (xap.util.LogFactory.s_loggingEnabled) + xap.session.DeclarativeArgumentParser.s_log.debug("Push result: " + result._resultObject); argumentStart = result._terminatingIndex; if (result._parseStatus==this._ParseResult.CLOSING_PAREN){ break; @@ -364,8 +366,8 @@ break; } } - - xap.session.DeclarativeArgumentParser.s_log.debug("Return parse result: " + args); + if (xap.util.LogFactory.s_loggingEnabled) + xap.session.DeclarativeArgumentParser.s_log.debug("Return parse result: " + args); return new this._ParseResult(args,argumentStart); } @@ -445,7 +447,8 @@ //TODO do we really want to do this? if (arg=="event"){ - xap.session.DeclarativeArgumentParser.s_log.debug("Found event string"); + if (xap.util.LogFactory.s_loggingEnabled) + xap.session.DeclarativeArgumentParser.s_log.debug("Found event string"); return clientEvent; } @@ -463,8 +466,8 @@ if (!element && elementName=="this"){ element = thisElement; } - - xap.session.DeclarativeArgumentParser.s_log.debug("Found element: " + element); + if (xap.util.LogFactory.s_loggingEnabled) + xap.session.DeclarativeArgumentParser.s_log.debug("Found element: " + element); if (element){ if (!elementAttribute) return element; @@ -477,6 +480,7 @@ } } catch(e){ + _session.handleException(e); //TODO report } @@ -572,7 +576,8 @@ //if we got the terminating char we are done if (c==terminatingCharacter){ - xap.session.DeclarativeArgumentParser.s_log.debug("Hit terminating char " + c + " result string=" + arg); + if (xap.util.LogFactory.s_loggingEnabled) + xap.session.DeclarativeArgumentParser.s_log.debug("Hit terminating char " + c + " result string=" + arg); result._resultObject = arg; result._terminatingIndex = nextChar; break;