incubator-xap-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jmarga...@apache.org
Subject svn commit: r501299 - /incubator/xap/trunk/codebase/src/xap/session/DeclarativeArgumentParser.js
Date Tue, 30 Jan 2007 03:04:26 GMT
Author: jmargaris
Date: Mon Jan 29 19:04:22 2007
New Revision: 501299

URL: http://svn.apache.org/viewvc?view=rev&rev=501299
Log:
removed some logging that happened even when logging was off
making things way slow

Modified:
    incubator/xap/trunk/codebase/src/xap/session/DeclarativeArgumentParser.js

Modified: incubator/xap/trunk/codebase/src/xap/session/DeclarativeArgumentParser.js
URL: http://svn.apache.org/viewvc/incubator/xap/trunk/codebase/src/xap/session/DeclarativeArgumentParser.js?view=diff&rev=501299&r1=501298&r2=501299
==============================================================================
--- incubator/xap/trunk/codebase/src/xap/session/DeclarativeArgumentParser.js (original)
+++ incubator/xap/trunk/codebase/src/xap/session/DeclarativeArgumentParser.js Mon Jan 29 19:04:22
2007
@@ -344,10 +344,12 @@
 		//why do we do +1 here? because if the last terminating character
 		//was , we need to start our search one AFTER the comma!
 		var result = this.parseArgument(argumentsString,argumentStart+1,sourceElement, clientEvent);
-		xap.session.DeclarativeArgumentParser.s_log.debug("Got back result " + result._resultObject);
+		if (xap.util.LogFactory.s_loggingEnabled)
+			xap.session.DeclarativeArgumentParser.s_log.debug("Got back result " + result._resultObject);
 		if (result._resultObject!=null){
 			args.push(result._resultObject);
-			xap.session.DeclarativeArgumentParser.s_log.debug("Push result: " + result._resultObject);
+			if (xap.util.LogFactory.s_loggingEnabled)
+				xap.session.DeclarativeArgumentParser.s_log.debug("Push result: " + result._resultObject);
 			argumentStart = result._terminatingIndex;
 			if (result._parseStatus==this._ParseResult.CLOSING_PAREN){
  				break;
@@ -364,8 +366,8 @@
 			break;
 		}
 	}
-	
-	xap.session.DeclarativeArgumentParser.s_log.debug("Return parse result: " + args);
+	if (xap.util.LogFactory.s_loggingEnabled)
+		xap.session.DeclarativeArgumentParser.s_log.debug("Return parse result: " + args);
 	return new this._ParseResult(args,argumentStart);
 }
 
@@ -445,7 +447,8 @@
 	
 	//TODO do we really want to do this?
 	if (arg=="event"){
-		xap.session.DeclarativeArgumentParser.s_log.debug("Found event string");
+		if (xap.util.LogFactory.s_loggingEnabled)
+			xap.session.DeclarativeArgumentParser.s_log.debug("Found event string");
 		return clientEvent;
 	}
 	
@@ -463,8 +466,8 @@
    		if (!element && elementName=="this"){
 	   		element = thisElement;
    		}
-   		
-   		xap.session.DeclarativeArgumentParser.s_log.debug("Found element: " + element);
+   		if (xap.util.LogFactory.s_loggingEnabled)
+   			xap.session.DeclarativeArgumentParser.s_log.debug("Found element: " + element);
                              	
    		if (element){
 	   		if (!elementAttribute) return element;   		
@@ -477,6 +480,7 @@
    		}
 	}
 	catch(e){ 
+		_session.handleException(e);
 		//TODO report
 	}
 	
@@ -572,7 +576,8 @@
 	        
 		//if we got the terminating char we are done
 		if (c==terminatingCharacter){
-			xap.session.DeclarativeArgumentParser.s_log.debug("Hit terminating char " + c + " result
string=" + arg);
+			if (xap.util.LogFactory.s_loggingEnabled)
+				xap.session.DeclarativeArgumentParser.s_log.debug("Hit terminating char " + c + " result
string=" + arg);
 			result._resultObject = arg;
 			result._terminatingIndex = nextChar;
 			break;



Mime
View raw message